Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Benchmark downloader #449

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

[WIP] Benchmark downloader #449

wants to merge 21 commits into from

Conversation

JulienT01
Copy link
Collaborator

@JulienT01 JulienT01 commented Apr 5, 2024 •
edited
Loading

Tools to download some benchmark.

linked to the issue : #395

Checklist

  • My code follows the style guideline
    To check :
    black --check examples rlberry *py
    flake8 --select F401,F405,D410,D411,D412 --exclude=rlberry/check_packages.py --per-file-ignores="init.py:F401",
  • I have commented my code, particularly in hard-to-understand areas,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works,
  • New and existing unit tests pass locally with my changes,
  • If updated the changelog if necessary,
  • I have set the label "ready for review" and the checks are all green.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

@JulienT01
Copy link
Collaborator Author

tool to download from here : https://github.com/DLR-RM/rl-trained-agents/tree/ca4371d8eef7c2eece81461f3d138d23743b2296

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

@github-actions GitHub Actions
Copy link

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

@github-actions GitHub Actions
Copy link

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

@github-actions GitHub Actions
Copy link

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

@github-actions GitHub Actions
Copy link

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

TimotheeMathieu
TimotheeMathieu reviewed Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@TimotheeMathieu TimotheeMathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe you could add an example in the example folder with download of benchmark + comparison with compare_agents_data ? And/or replace the data being compared in the user guide with for the comparison user guide page with data from benchmark?

rlberry/manager/comparison.py Outdated Show resolved Hide resolved
rlberry/benchmarks/benchmark_utils.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

@github-actions GitHub Actions
Copy link

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

@github-actions GitHub Actions
Copy link

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

@github-actions GitHub Actions
Copy link

Hello,
The build of the doc succeeded. The documentation preview is available here:
https://rlberry-py.github.io/rlberry/preview_pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimotheeMathieu TimotheeMathieu TimotheeMathieu left review comments

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulienT01 @TimotheeMathieu